Enhance broker support #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirreza8002
force-pushed
the
val
branch
3 times, most recently
from
bef78ae to
462d942
Compare
cunla
reviewed
Nov 14, 2024
|
I'll take a look at the comments libvalkey is not needed per say it's an optional C-binding that improves performance of valkey-py |
|
Hi, I made some changes - let me know what you think. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the initial version, there are more things that need to be done
i'll update the docs and README after i'm sure the code works
i've tried to make valkey an optional dependency,
loosen up redis so other servers can be configured easier
and changed some names to be more abstract
waiting for some feedback 👐🏼
related issue: #189